Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add windows support #157

Merged
merged 1 commit into from
Jan 26, 2024
Merged

feat: Add windows support #157

merged 1 commit into from
Jan 26, 2024

Conversation

lukapeschke
Copy link
Collaborator

addressing #154

@lukapeschke lukapeschke changed the title ci: build windows wheels feat: Add windows support Jan 26, 2024
@lukapeschke lukapeschke marked this pull request as ready for review January 26, 2024 15:34
@lukapeschke lukapeschke merged commit 65cd95b into main Jan 26, 2024
41 checks passed
@lukapeschke lukapeschke deleted the add-windows-support branch January 26, 2024 15:39
@alexander-beedie
Copy link
Contributor

Great! Will enable in our unit tests once there's an associated release ✌️

@lukapeschke
Copy link
Collaborator Author

Nice, I'll try to push a fix for #160 ASAP and do a release afterwards 🙂

@mcrumiller
Copy link

Heh, I just had a back and forth with our IT department about our internal PyPi repo and why fastexcel worked in our JupyterHub environment but not locally...turns out it's because locally I'm on Windows :D. Glad to find this PR here. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants